Skip to content

Enable core dumps and logs for mac and linux unit test crashes. #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 22, 2020
Merged

Enable core dumps and logs for mac and linux unit test crashes. #89

merged 16 commits into from
Jul 22, 2020

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jul 20, 2020

Archives are uploaded at the end of Github Actions for linux & mac debug targets.

On linux archives include:

  • core files of crashes logged via the OS.
  • binary files of the unit tests.

On mac archives incude:

  • file generated in ~/Library/Logs/DiagnosticReports .
  • binary files of the unit tests.

@DellaBitta DellaBitta marked this pull request as ready for review July 20, 2020 14:04
@DellaBitta DellaBitta requested review from a-maurice and vimanyu July 20, 2020 14:04
vimanyu
vimanyu requested changes Jul 20, 2020
View reviewed changes
Copy link
Contributor

@vimanyu vimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except we might have to discuss later if we should have separate workflow files for each os on desktop as we have quite a few special cases now. Maybe we can avoid the special makefiles vs ninja cases at the very least.

@DellaBitta
Copy link
Contributor Author

DellaBitta commented Jul 21, 2020

Updated the branch with those suggested changes.

vimanyu
vimanyu previously approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@vimanyu vimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

a-maurice
a-maurice previously approved these changes Jul 21, 2020
View reviewed changes
@DellaBitta DellaBitta dismissed stale reviews from a-maurice and vimanyu via 0bb877a July 22, 2020 12:16
vimanyu
vimanyu approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@vimanyu vimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DellaBitta DellaBitta merged commit 65dcca7 into dev Jul 22, 2020
@DellaBitta DellaBitta deleted the feature/ddb-mac-linux-crash-dumps branch July 22, 2020 16:58
@firebase firebase locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vimanyu vimanyu vimanyu approved these changes

@a-maurice a-maurice a-maurice left review comments

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DellaBitta @vimanyu @a-maurice @googlebot